Replace deprecated functions with standard JS #194
Conversation
| method returns null. It is necessary to use the method | ||
| 'findAncestorClass(passwordField, "tr")' instead of. | ||
| 'passwordField.closest(".tr")' instead. |
There was a problem hiding this comment.
I don't understand the extra "." that is added before the tag. The new code seems to already add a leading ".". Is there a reason we need two dots?
| 'passwordField.closest(".tr")' instead. | |
| 'passwordField.closest("tr")' instead. | |
There was a problem hiding this comment.
The new code is not called from here, instead we're calling closest directly so we have to add the dot ourselves.
e.closest("tr") has the same semantic as the deprected findAncestor(e,"tr")
e.closest(".tr") has the same semantic as the deprected findAncestorClass(e,"tr")
It's also questionable if using both e.closest("TR") and e.closest(".tr") is still needed, given that required core version is 2.387 now which includes the tables-to-divs migration already.
There was a problem hiding this comment.
Thanks very much. I should have read the deprecated method more carefully. Your description makes it clear. Thanks again
...ugins/authorizeproject/strategy/SpecificUsersAuthorizationStrategy/checkPasswordRequested.js
Show resolved
Hide resolved
MarkEWaite
added
the
chore
This inlines a deprecated function https://github.com/jenkinsci/jenkins/blob/551043065bc672102fb8b07e8008f959ebc566fa/war/src/main/webapp/scripts/hudson-behavior.js#L453
Testing done
Submitter checklist