Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebClient missing polyfill #236

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

janfaracik
Copy link
Contributor

Thanks to @basil for raising awareness of this - jenkinsci/jenkins#9148 (comment).

We're now using the JavaScript fetch() API for the builds widget which requires a polyfill for HtmlUnit. This polyfill is enabled by default as part of the Jenkins test harness createWebClient(), however in this case that method wasn't used as a couple of methods of WebClient needed to be overridden.

This MR enables the polyfill for that web client.

Testing done

  • Test passes on latest snapshot

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik requested a review from a team as a code owner June 14, 2024 21:00
@github-actions github-actions bot added the tests Automated test addition or improvement label Jun 14, 2024
@basil basil added the developer Affects developers and maintainers label Jun 14, 2024
@MarkEWaite MarkEWaite merged commit 7edda3e into jenkinsci:master Jun 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Affects developers and maintainers tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants