Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork matrix-auth into this plugin #460

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

timja
Copy link
Member

@timja timja commented Aug 23, 2023

see jenkinsci/matrix-auth-plugin#145 (comment)

Testing done

  • Tested JCasC
  • Configuring users in global and project configuration

There is certainly risk to this but I've done my best checking it.

Submitter checklist

@timja timja marked this pull request as ready for review August 24, 2023 09:50
@timja timja merged commit 252dae1 into jenkinsci:master Aug 24, 2023
13 checks passed
@timja timja deleted the fork-matrix-auth branch August 24, 2023 09:51
@KalleOlaviNiemitalo
Copy link

In jenkinsci/matrix-auth-plugin#144, hpi.compatibleSinceVersion was raised because the Pipeline and Job DSL syntaxes changed. Does this PR cause a similar incompatibility in azure-ad?

@timja
Copy link
Member Author

timja commented Aug 24, 2023

👉 #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants