Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI should use the DNS server that is also defined in the same VNET #126

Closed
4 tasks done
sparsick opened this issue Apr 7, 2022 · 0 comments
Closed
4 tasks done

ACI should use the DNS server that is also defined in the same VNET #126

sparsick opened this issue Apr 7, 2022 · 0 comments
Labels
enhancement

Comments

@sparsick
Copy link
Contributor

sparsick commented Apr 7, 2022 •
edited
Loading

What feature do you want to see added?

When you define a DNS server in the VNET, where also the ACIs should be deployed and this DNS server should be used by these ACIs, you have to add a dnsConfig section in the ARM deployment template.

Therefore, the Private IP Address configuration section should be extended by a property where the name servers can be configured.

To-dos

  • Adjust UI
  • Adjust deploymeny template
  • Extend casc test
  • Extend documentation

Upstream changes

No response
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 8, 2022
@sparsick
jenkinsci#126: adjust ui to set dns configuration
55a719d
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 8, 2022
@sparsick
jenkinsci#126: adjust ui to set dns configuration
19eb4d1
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 8, 2022
@sparsick
jenkinsci#126: adjust deployment template to handle dns configuration
b1808a7
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 14, 2022
@sparsick
jenkinsci#126: adjust after code review
a769664
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 14, 2022
@sparsick
jenkinsci#126: add more resilience for configuration values
b98dfe7 
- ignoring whitespaces in image name
- ignore empty dns server name
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 14, 2022
@sparsick
jenkinsci#126: adjust jcac test with new configuration possibilities
87e95ab
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 14, 2022
@sparsick
jenkinsci#126: add tool tip for dns configuration
674e062
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 15, 2022
@sparsick
jenkinsci#126: refactoring after code review
8ad1c87 
- using better names
@timja timja closed this as completed Apr 15, 2022
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 19, 2022
@sparsick
jenkinsci#126: rename field names in config.jelly that they matches t…
2514199 
…he refactoring of the java class
@sparsick sparsick mentioned this issue Apr 19, 2022
Merged
6 tasks
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Apr 19, 2022
@sparsick
jenkinsci#126: add configRoundTrip test
aea631c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sparsick @timja