Update basic templates default Java version to JDK 17 #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Windows I switched from AdoptOpenJDK to Temurin (the new name for the project) For Ubuntu we will need to change the apt-get install
timja
reviewed
Oct 4, 2024
| @@ -1,6 +1,6 @@ | |||
| Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1')) | |||
|
|
|||
| choco install -y adoptopenjdk11 | |||
| choco install -y temurin17 | |||
There was a problem hiding this comment.
Looks like these scripts were broken by chocolatey 2, I'm testing a fix atm
There was a problem hiding this comment.
I had considered switching this to use winget:
winget install EclipseAdoptium.Temurin.17.JDKThere was a problem hiding this comment.
winget is only available from window server 2022+ as far as I remember
There was a problem hiding this comment.
The alternative would be to use the Adoptium API directly
# Set the URL for the Adoptium API
$downloadUrl = "https://api.adoptium.net/v3/installer/latest/17/ga/windows/x64/jdk/hotspot/normal/eclipse"
# Specify the download location
$destination = "$env:TEMP\temurin17.msi"
# Download the JDK installer
Invoke-WebRequest -Uri $downloadUrl -OutFile $destination
# Install the JDK
Start-Process -FilePath msiexec.exe -ArgumentList "/i", $destination, "/quiet", "/norestart" -Wait
# Clean up the installer file
Remove-Item $destinationThere was a problem hiding this comment.
Probably ok but for now I've pinned chocolatey to 1.x and it worked:
Chocolatey 2.x requires .net 4.8 which isn't installed by default on older windows and requires a reboot to install on those.
timja
reviewed
Oct 4, 2024
| @@ -4,6 +4,6 @@ set -ex | |||
|
|
|||
| # Install Java | |||
| sudo apt-get -y update | |||
| sudo apt-get install -y default-jdk | |||
| sudo apt-get install -y openjdk-17-jdk | |||
There was a problem hiding this comment.
worked:
java.vm.name = OpenJDK 64-Bit Server VM
java.vm.specification.name = Java Virtual Machine Specification
java.vm.specification.vendor = Oracle Corporation
java.vm.specification.version = 17
java.vm.vendor = Ubuntu
java.vm.version = 17.0.12+7-Ubuntu-1ubuntu220.04
timja
reviewed
Oct 4, 2024
| @@ -128,7 +128,6 @@ public final class Constants { | |||
| public static final String WINDOWS_SERVER_2022 = "Windows Server 2022"; | |||
| public static final String WINDOWS_SERVER_2019 = "Windows Server 2019"; | |||
| public static final String WINDOWS_SERVER_2016 = "Windows Server 2016"; | |||
| public static final String UBUNTU_1604_LTS = "Ubuntu 16.04 LTS"; | |||
There was a problem hiding this comment.
openjdk-17-jdk is not available on Ubuntu 16, given its so far out of support I've removed it from the list.
timja
changed the title
timja
approved these changes
Oct 4, 2024
|
Thanks! |
when do you expect we will have a new release of this plugin? |
|
next 5-10 mins or so i'd expect, its automated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going forwards Jenkins will only support JDK17+ (https://www.jenkins.io/blog/2024/06/11/require-java-17/)
For Windows I switched from AdoptOpenJDK to Temurin (the new name for the project)
For Ubuntu I've changed to explicitly stating JDK17
Testing done
Submitter checklist