-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade some dependencies #2471
Conversation
@@ -37,7 +37,7 @@ | |||
<groupId>org.eclipse.jgit</groupId> | |||
<artifactId>org.eclipse.jgit.ssh.jsch</artifactId> | |||
<!-- TODO this is hard to manage; if needed, should be in BOM --> | |||
<version>6.5.0.202303070854-r</version> | |||
<version>6.6.0.202305301015-r</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligned with the version shipped in the version of the Git plugin shipped in BOM 2278.v47b_4508e256a (consumed below).
@@ -66,6 +66,7 @@ | |||
<dependency> | |||
<groupId>org.jvnet.hudson.plugins</groupId> | |||
<artifactId>favorite</artifactId> | |||
<version>2.4.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest available version at the time of this writing.
@@ -232,7 +232,7 @@ | |||
<dependency> | |||
<groupId>io.jenkins.tools.bom</groupId> | |||
<artifactId>bom-2.401.x</artifactId> | |||
<version>2102.v854b_fec19c92</version> | |||
<version>2278.v47b_4508e256a</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest available version at the time of this writing.
<dependency> | ||
<groupId>org.jvnet.hudson.plugins</groupId> | ||
<artifactId>favorite</artifactId> | ||
<version>2.3.1</version> | ||
<exclusions> | ||
<!-- Upper bound fix: Remove it once token-micro plugin is fixed to remove dependency on asm-tree | ||
PR https://github.com/jenkinsci/token-macro-plugin/pull/31. Fix to be available in 2.4.0. | ||
--> | ||
<exclusion> | ||
<groupId>org.ow2.asm</groupId> | ||
<artifactId>asm</artifactId> | ||
</exclusion> | ||
<exclusion> | ||
<groupId>org.ow2.asm</groupId> | ||
<artifactId>asm-tree</artifactId> | ||
</exclusion> | ||
</exclusions> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to pin such an old version in the dependency management section. The linked PR is five years old.
<dependency> | ||
<groupId>org.jenkins-ci.plugins</groupId> | ||
<artifactId>ant</artifactId> | ||
<version>1.11</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to pin such an old version in the dependency management section.
No description provided.