Skip to content

Commit

Permalink
Add docker-workflow plugin to the managed set (#2464)
Browse files Browse the repository at this point in the history
* Add docker-workflow plugin to managed set

* Remove docker-commons from sample-plugin dependencies

README advises that the dependencies in the sample plugin should be
maintained as we would any other plugin, with the top level
dependencies declared and the transitive dependencies calculated by
Maven.

Since docker-workflow depends on docker-commons, we don't need to
declare docker-commons in the sample plugin.

---------

Co-authored-by: Basil Crow <me@basilcrow.com>
  • Loading branch information
MarkEWaite and basil authored Sep 6, 2023
1 parent 6c05958 commit 3f87ffe
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions bom-weekly/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,11 @@
<artifactId>docker-java-api</artifactId>
<version>3.3.1-79.v20b_53427e041</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-workflow</artifactId>
<version>572.v950f58993843</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>durable-task</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions sample-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -421,12 +421,12 @@
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-commons</artifactId>
<artifactId>docker-java-api</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-java-api</artifactId>
<artifactId>docker-workflow</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down

0 comments on commit 3f87ffe

Please sign in to comment.