Skip to content

Commit

Permalink
Remove docker-commons from sample-plugin dependencies
Browse files Browse the repository at this point in the history
README advises that the dependencies in the sample plugin should be
maintained as we would any other plugin, with the top level
dependencies declared and the transitive dependencies calculated by
Maven.

Since docker-workflow depends on docker-commons, we don't need to
declare docker-commons in the sample plugin.
  • Loading branch information
MarkEWaite committed Sep 5, 2023
1 parent ef59e02 commit f0bb487
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions sample-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -419,11 +419,6 @@
<artifactId>dashboard-view</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-commons</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>docker-java-api</artifactId>
Expand Down

0 comments on commit f0bb487

Please sign in to comment.