Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugin-util-api.version from 2.17.0 to 2.18.0 in /bom-weekly #1521

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 26, 2022

Bumps plugin-util-api.version from 2.17.0 to 2.18.0.
Updates plugin-util-api from 2.17.0 to 2.18.0

Release notes

Sourced from plugin-util-api's releases.

v2.18.0 🎁

📦 Dependency Updates

💥 Breaking changes

Bump Jenkins LTS baseline to 2.346.x

Commits
  • 37d70fd [maven-release-plugin] prepare release v2.18.0
  • b4e82aa Merge pull request #212 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...
  • 6b162f6 Merge pull request #213 from jenkinsci/dependabot/maven/org.testcontainers-te...
  • b2288df Bump testcontainers from 1.17.3 to 1.17.4
  • 9d67d6c Bump analysis-pom from 5.34.0 to 5.35.0
  • 547edde Merge pull request #211 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...
  • 3f53e07 Bump analysis-pom from 5.33.0 to 5.34.0
  • e28a653 Merge pull request #207 from jenkinsci/dependabot/github_actions/kentaro-m/au...
  • d9f656e Merge pull request #209 from jenkinsci/dependabot/github_actions/release-draf...
  • 0d49d96 Merge pull request #208 from jenkinsci/dependabot/github_actions/actions/chec...
  • Additional commits viewable in compare view

Updates plugin-util-api from 2.17.0 to 2.18.0

Release notes

Sourced from plugin-util-api's releases.

v2.18.0 🎁

📦 Dependency Updates

💥 Breaking changes

Bump Jenkins LTS baseline to 2.346.x

Commits
  • 37d70fd [maven-release-plugin] prepare release v2.18.0
  • b4e82aa Merge pull request #212 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...
  • 6b162f6 Merge pull request #213 from jenkinsci/dependabot/maven/org.testcontainers-te...
  • b2288df Bump testcontainers from 1.17.3 to 1.17.4
  • 9d67d6c Bump analysis-pom from 5.34.0 to 5.35.0
  • 547edde Merge pull request #211 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...
  • 3f53e07 Bump analysis-pom from 5.33.0 to 5.34.0
  • e28a653 Merge pull request #207 from jenkinsci/dependabot/github_actions/kentaro-m/au...
  • d9f656e Merge pull request #209 from jenkinsci/dependabot/github_actions/release-draf...
  • 0d49d96 Merge pull request #208 from jenkinsci/dependabot/github_actions/actions/chec...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `plugin-util-api.version` from 2.17.0 to 2.18.0.

Updates `plugin-util-api` from 2.17.0 to 2.18.0
- [Release notes](https://github.com/jenkinsci/plugin-util-api-plugin/releases)
- [Changelog](https://github.com/jenkinsci/plugin-util-api-plugin/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-util-api-plugin@v2.17.0...v2.18.0)

Updates `plugin-util-api` from 2.17.0 to 2.18.0
- [Release notes](https://github.com/jenkinsci/plugin-util-api-plugin/releases)
- [Changelog](https://github.com/jenkinsci/plugin-util-api-plugin/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-util-api-plugin@v2.17.0...v2.18.0)

---
updated-dependencies:
- dependency-name: io.jenkins.plugins:plugin-util-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.jenkins.plugins:plugin-util-api:tests
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 26, 2022
@dependabot dependabot bot requested a review from jglick October 26, 2022 22:28
@jglick jglick enabled auto-merge (squash) October 27, 2022 02:58
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Nov 13, 2022

The checks-api test fails with a message that I don't know how to resolve. It says:

06:01:50  [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on project checks-api: 
Execution default-cli of goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test failed: org.junit.platform.commons.JUnitException: 
TestEngine with ID 'archunit' failed to discover tests: ExceptionInInitializerError: class com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule cannot be cast to class com.tngtech.archunit.lang.syntax.elements.ClassesShouldConjunction (com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule and com.tngtech.archunit.lang.syntax.elements.ClassesShouldConjunction are in unnamed module of loader org.apache.maven.surefire.booter.IsolatedClassLoader @17e725fb) -> [Help 1]
[795](https://ci.jenkins.io/job/Tools/job/bom/job/PR-1521/5/pipeline-console/?selected-node=2930#log-795)
06:01:50  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on project checks-api: 
Execution default-cli of goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test failed: org.junit.platform.commons.JUnitException: 
TestEngine with ID 'archunit' failed to discover tests

I don't recognize the message "TestEngine with ID 'archunit' failed to discover tests"

@uhafner
Copy link
Member

uhafner commented Nov 14, 2022

@MarkEWaite The reason is that the checks API is being build with a target JDK 11, but the plugin is still targeting JDK 8. (It compiles well with JDK 11 and 17, the problem is the target that is changed by the BOM).

I also asked on https://groups.google.com/g/jenkinsci-dev/c/dpWNgtKwgkw/m/Aj-PhO2BBgAJ but nobody could help me yet to check why we do not build plugins with the target that a plugin requests.

@jglick
Copy link
Member

jglick commented Nov 14, 2022

Neither bom nor plugin-compat-tester does anything of the sort that I am aware of. Maybe it is the unusual assertj-assertions-generator-maven-plugin which is at fault. Or maybe something in analysis-pom, which is nonstandard and should IMO be deprecated; use the standard plugin-pom directly. What https://github.com/jenkinsci/analysis-pom-plugin/blob/bcc55fbea30676a1a674d84c7ac897c24a682300/pom.xml#L242-L259 is, nothing else that I am aware of uses it, and it seems to be breaking here.

@MarkEWaite MarkEWaite marked this pull request as draft November 30, 2022 02:40
auto-merge was automatically disabled November 30, 2022 02:40

Pull request was converted to draft

@MarkEWaite
Copy link
Contributor

@dependabot close

Prefer #1614 that offers a newer version

@dependabot dependabot bot closed this Dec 2, 2022
@dependabot dependabot bot deleted the dependabot/maven/bom-weekly/plugin-util-api.version-2.18.0 branch December 2, 2022 23:18
@uhafner
Copy link
Member

uhafner commented Dec 6, 2022

Neither bom nor plugin-compat-tester does anything of the sort that I am aware of.

Hmm, in the console log I get:

[INFO] --- maven-hpi-plugin:3.33:initialize (default-initialize) @ checks-api ---
[INFO] Setting maven.compiler.release to 11
[INFO] Setting maven.compiler.testRelease to 11
[INFO]

I have no idea what is causing that in the BOM builds. On ci.jenkins.io I get:

17:15:27  [INFO] --- maven-hpi-plugin:3.35:initialize (default-initialize) @ checks-api ---
17:15:27  [INFO] 
17:15:27  [INFO] --- gmavenplus-plugin:2.1.0:addTestSources (test-in-groovy) @ checks-api ---
17:15:27  [WARNING] The POM for org.jenkins-ci.tools:maven-hpi-plugin:jar:3.35 is missing, no dependency information available

Maybe it is the unusual assertj-assertions-generator-maven-plugin which is at fault. Or maybe something in analysis-pom, which is nonstandard and should IMO be deprecated; use the standard plugin-pom directly. What https://github.com/jenkinsci/analysis-pom-plugin/blob/bcc55fbea30676a1a674d84c7ac897c24a682300/pom.xml#L242-L259 is, nothing else that I am aware of uses it, and it seems to be breaking here.

Well, I am using AssertJ to replace the poor assertEquals assertions of JUnit. Additionally I am using ArchUnit to run architecture tests. So these libraries are both required to run my tests and work fine in standard CI.

I don't think that running architecture tests makes sense in the BOM though. Is there a way to specify the tests that run in the BOM? Currently I separated my tests in unit tests (maven surefire) and integration tests (maven failsafe).

But anyway, my plan is to move all my baselines to Java 11 in the Christmas break, maybe then all those problems disappear...

@jglick
Copy link
Member

jglick commented Dec 6, 2022

I don't think that running architecture tests makes sense in the BOM though. Is there a way to specify the tests that run in the BOM? Currently I separated my tests in unit tests (maven surefire) and integration tests (maven failsafe).

Presumably the unit tests are not going to be affected by dependency changes; it is the integration tests which are important to run during BOM builds.

replace the poor assertEquals assertions of JUnit

Hamcrest? Which is just a library and does not require a special Maven plugin.

Anyway it sounds like ArchUnit (whatever that is) is the problem here. Maybe switching to Java 11 will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants