-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump plugin-util-api.version from 2.17.0 to 2.18.0 in /bom-weekly #1521
Bump plugin-util-api.version from 2.17.0 to 2.18.0 in /bom-weekly #1521
Conversation
Bumps `plugin-util-api.version` from 2.17.0 to 2.18.0. Updates `plugin-util-api` from 2.17.0 to 2.18.0 - [Release notes](https://github.com/jenkinsci/plugin-util-api-plugin/releases) - [Changelog](https://github.com/jenkinsci/plugin-util-api-plugin/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-util-api-plugin@v2.17.0...v2.18.0) Updates `plugin-util-api` from 2.17.0 to 2.18.0 - [Release notes](https://github.com/jenkinsci/plugin-util-api-plugin/releases) - [Changelog](https://github.com/jenkinsci/plugin-util-api-plugin/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-util-api-plugin@v2.17.0...v2.18.0) --- updated-dependencies: - dependency-name: io.jenkins.plugins:plugin-util-api dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.jenkins.plugins:plugin-util-api:tests dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
The checks-api test fails with a message that I don't know how to resolve. It says:
I don't recognize the message "TestEngine with ID 'archunit' failed to discover tests" |
@MarkEWaite The reason is that the checks API is being build with a target JDK 11, but the plugin is still targeting JDK 8. (It compiles well with JDK 11 and 17, the problem is the target that is changed by the BOM). I also asked on https://groups.google.com/g/jenkinsci-dev/c/dpWNgtKwgkw/m/Aj-PhO2BBgAJ but nobody could help me yet to check why we do not build plugins with the target that a plugin requests. |
Neither |
Pull request was converted to draft
@dependabot close Prefer #1614 that offers a newer version |
Hmm, in the console log I get:
I have no idea what is causing that in the BOM builds. On ci.jenkins.io I get:
Well, I am using AssertJ to replace the poor I don't think that running architecture tests makes sense in the BOM though. Is there a way to specify the tests that run in the BOM? Currently I separated my tests in unit tests (maven surefire) and integration tests (maven failsafe). But anyway, my plan is to move all my baselines to Java 11 in the Christmas break, maybe then all those problems disappear... |
Presumably the unit tests are not going to be affected by dependency changes; it is the integration tests which are important to run during BOM builds.
Hamcrest? Which is just a library and does not require a special Maven plugin. Anyway it sounds like ArchUnit (whatever that is) is the problem here. Maybe switching to Java 11 will help. |
Bumps
plugin-util-api.version
from 2.17.0 to 2.18.0.Updates
plugin-util-api
from 2.17.0 to 2.18.0Release notes
Sourced from plugin-util-api's releases.
Commits
37d70fd
[maven-release-plugin] prepare release v2.18.0b4e82aa
Merge pull request #212 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...6b162f6
Merge pull request #213 from jenkinsci/dependabot/maven/org.testcontainers-te...b2288df
Bump testcontainers from 1.17.3 to 1.17.49d67d6c
Bump analysis-pom from 5.34.0 to 5.35.0547edde
Merge pull request #211 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...3f53e07
Bump analysis-pom from 5.33.0 to 5.34.0e28a653
Merge pull request #207 from jenkinsci/dependabot/github_actions/kentaro-m/au...d9f656e
Merge pull request #209 from jenkinsci/dependabot/github_actions/release-draf...0d49d96
Merge pull request #208 from jenkinsci/dependabot/github_actions/actions/chec...Updates
plugin-util-api
from 2.17.0 to 2.18.0Release notes
Sourced from plugin-util-api's releases.
Commits
37d70fd
[maven-release-plugin] prepare release v2.18.0b4e82aa
Merge pull request #212 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...6b162f6
Merge pull request #213 from jenkinsci/dependabot/maven/org.testcontainers-te...b2288df
Bump testcontainers from 1.17.3 to 1.17.49d67d6c
Bump analysis-pom from 5.34.0 to 5.35.0547edde
Merge pull request #211 from jenkinsci/dependabot/maven/org.jvnet.hudson.plug...3f53e07
Bump analysis-pom from 5.33.0 to 5.34.0e28a653
Merge pull request #207 from jenkinsci/dependabot/github_actions/kentaro-m/au...d9f656e
Merge pull request #209 from jenkinsci/dependabot/github_actions/release-draf...0d49d96
Merge pull request #208 from jenkinsci/dependabot/github_actions/actions/chec...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)