-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to jenkinsci/plugin-compat-tester#505 #1908
Conversation
Not a whole lot, as it turns out: just jenkinsci/maven-hpi-plugin#461 (and therefore jenkinsci/plugin-compat-tester#505) from the Jenkins side, based on my preliminary testing. I will run it through the ringer in this next build. The above two PRs will require testing from "the other consumer." |
Pretty decent run overall, just 4 failures:
The first two are our old friend jenkinsci/matrix-auth-plugin#133. |
67ed2df
to
e674756
Compare
e674756
to
b93e7d9
Compare
overrideWarAdditions
The only failure in https://ci.jenkins.io/job/Tools/job/bom/job/PR-1908/11/ was a flake regarding DNS resolution of github.com. Otherwise all tests passed. @jenkinsci/bom-developers I require a merge of this for my ongoing PCT work. |
I think that the DNS resolution failure in the test should not block the merge of this pull request. Merging and accepting that if there is a surprise in that merge, we will revert it. |
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Adapt to jenkinsci/plugin-compat-tester#505 by:
-DoverrideWarAdditions=true
which has now been removed from Maven HPI pluginorg.jenkinsci.plugins.matrixauth.integrations.casc.ImportTest
because Switch JCasC test to RealJenkinsRule matrix-auth-plugin#136 still has not been merged and releasedCloses #1912