Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise new bom line (2.277) #409

Merged
merged 12 commits into from
Feb 2, 2021
Merged

Initialise new bom line (2.277) #409

merged 12 commits into from
Feb 2, 2021

Conversation

timja
Copy link
Member

@timja timja commented Jan 31, 2021

No description provided.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I would suggest merging it early so that all tables-to-divs changes flow in

@timja
Copy link
Member Author

timja commented Jan 31, 2021

+1. I would suggest merging it early so that all tables-to-divs changes flow in

yes we did this last time too, once selection is complete assuming green will merge

@timja
Copy link
Member Author

timja commented Jan 31, 2021

nice only token macro failing

@jglick jglick marked this pull request as draft February 1, 2021 14:27
@jglick
Copy link
Member

jglick commented Feb 1, 2021

so that all tables-to-divs changes flow in

I doubt tables-to-divs regressions would routinely show up in PCT. Maybe for configRoundtrip tests.

failFast Outdated Show resolved Hide resolved
@timja
Copy link
Member Author

timja commented Feb 1, 2021

so this PR (merged 5 months ago 🤯) jenkinsci/pipeline-model-definition-plugin#402, needs releasing to fix declarative pipeline PCT

I guess we can just ignore the tests and move on?

@jglick jglick marked this pull request as ready for review February 1, 2021 22:52
@jglick jglick marked this pull request as draft February 1, 2021 22:53
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming this baseline does get selected.

@bitwiseman
Copy link
Contributor

@timja
https://github.com/jenkinsci/pipeline-model-definition-plugin/releases/tag/pipeline-model-definition-1.8.0

pct.sh Outdated Show resolved Hide resolved
@timja timja marked this pull request as ready for review February 2, 2021 12:14
@jglick jglick enabled auto-merge February 2, 2021 14:48
@jglick jglick added the enhancement New feature or request label Feb 2, 2021
This was referenced Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants