Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local storage instead of cookies for settings #1023

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Oct 23, 2024

Fixes #968 by not using cookies at all.

Testing done

Manually checked that changing settings and reloading the page preserves settings.
npm run test passes locally.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • [n/a ] Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@zbynek zbynek requested a review from a team as a code owner October 23, 2024 06:01
@timja
Copy link
Member

timja commented Nov 3, 2024

@jan-molak possible to take a look please?

@timja
Copy link
Member

timja commented Nov 3, 2024

or @basil maybe?

@basil basil merged commit 18a5ca6 into jenkinsci:master Nov 4, 2024
15 checks passed
@timja timja mentioned this pull request Jan 8, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove YUI from build-monitor
3 participants