JENKINS-65262 Avoid holding queue lock when updating GitHub (#97)

jenkinsci · Apr 1, 2021 · b97c8fa · b97c8fa
1 parent 3e59698
commit b97c8fa
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 6 deletions.
diff --git a/pom.xml b/pom.xml
@@ -131,6 +131,12 @@
                 <serialVersionUID>1</serialVersionUID>
                 <justification>Adding actions list with an initial empty value should not break the compatibility.</justification>
               </item>
+              <item>
+                <regex>true</regex>
+                <code>java.annotation.*</code>
+                <annotation>@edu.umd.cs.findbugs.annotations.*</annotation>
+                <justification>Annotation should be safe to change.</justification>
+              </item>
               <item>
                 <regex>true</regex>
                 <code>java.missing.*</code>

diff --git a/spotbugs-exclusion-filter.xml b/spotbugs-exclusion-filter.xml
@@ -0,0 +1,2 @@
+<FindBugsFilter>
+</FindBugsFilter>
diff --git a/src/main/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisher.java b/src/main/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisher.java
@@ -1,8 +1,10 @@
 package io.jenkins.plugins.checks.status;
 
 import edu.umd.cs.findbugs.annotations.CheckForNull;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.Extension;
 import hudson.FilePath;
+import hudson.model.Computer;
 import hudson.model.Job;
 import hudson.model.Queue;
 import hudson.model.Result;
@@ -96,7 +98,7 @@ static Optional<String> getChecksName(final Job<?, ?> job) {
     }
 
     @CheckForNull
-    static ChecksOutput getOutput(final Run run) {
+    static ChecksOutput getOutput(final Run<?, ?> run) {
         if (!(run instanceof FlowExecutionOwner.Executable)) {
             return null;
         }
@@ -111,7 +113,7 @@ static ChecksOutput getOutput(final Run run) {
         return getOutput(run, execution);
     }
 
-    static ChecksOutput getOutput(final Run run, final FlowExecution execution) {
+    static ChecksOutput getOutput(final Run<?, ?> run, final FlowExecution execution) {
         return new FlowExecutionAnalyzer(run, execution, findProperties(run.getParent()).isSuppressLogs(run.getParent())).extractOutput();
     }
 
@@ -137,9 +139,16 @@ public void onEnterWaiting(final Queue.WaitingItem wi) {
                 return;
             }
 
-            final Job job = (Job) wi.task;
-            getChecksName(job).ifPresent(checksName -> publish(ChecksPublisherFactory.fromJob(job, TaskListener.NULL),
-                    ChecksStatus.QUEUED, ChecksConclusion.NONE, checksName, null));
+            final Job<?, ?> job = (Job<?, ?>) wi.task;
+            getChecksName(job).ifPresent(checksName -> runAsync(() -> {
+                ChecksPublisher publisher = ChecksPublisherFactory.fromJob(job, TaskListener.NULL);
+                publish(publisher, ChecksStatus.QUEUED, ChecksConclusion.NONE, checksName, null);
+            }));
+        }
+
+        @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
+        private void runAsync(Runnable run) {
+            Computer.threadPoolForRemoting.submit(run);
         }
     }
 
@@ -236,7 +245,7 @@ public void onNewHead(final FlowNode node) {
 
             Run<?, ?> run;
             try {
-                run = (Run) node.getExecution().getOwner().getExecutable();
+                run = (Run<?, ?>) node.getExecution().getOwner().getExecutable();
             }
             catch (IOException e) {
                 LOGGER.log(Level.WARNING, "Unable to find Run from flow node.", e);

diff --git a/src/test/java/io/jenkins/plugins/checks/api/TruncatedStringTest.java b/src/test/java/io/jenkins/plugins/checks/api/TruncatedStringTest.java
@@ -1,5 +1,6 @@
 package io.jenkins.plugins.checks.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -15,6 +16,7 @@
  */
 @SuppressWarnings({"VisibilityModifier", "MissingJavadocMethod"})
 @RunWith(Parameterized.class)
+@SuppressFBWarnings("NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR")
 public class TruncatedStringTest {
     private static final String MESSAGE = "Truncated";  // length 9
 

diff --git a/src/test/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisherITest.java b/src/test/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisherITest.java
@@ -1,5 +1,6 @@
 package io.jenkins.plugins.checks.status;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.model.Job;
 import hudson.model.Result;
 import hudson.model.Run;
@@ -26,6 +27,7 @@
  * accordingly.
  */
 @SuppressWarnings("PMD.AddEmptyString")
+@SuppressFBWarnings("NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR")
 public class BuildStatusChecksPublisherITest extends IntegrationTestWithJenkinsPerTest {
 
     /**