Migrate to AbstractStatusChecksProperties class. #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current interface
StatusChecksProperties
is incompatible for future changes (e.g. #51), so this PR migrates toAbstractStatusChecksProperties
(although the default method can be used, since the implementation is still in our control, we'd better refactor it).In order to make the migration smooth without breaking the compatibility (if necessary), here is the plan or some steps for it:
StatusChecksProperties
interface and add theAbstractStatusChecksProperties
class (this PR)BuildStatusChecksPublisher
to allow it accepts implementations for both the old interface and new abstract classGitHubStatusChecksProperties
to extendAbstractStatusChecksProperties
StatusChecksProperties
interface