Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AbstractStatusChecksProperties class. #52

Merged
merged 4 commits into from
Dec 21, 2020

Conversation

XiongKezhi
Copy link
Contributor

The current interface StatusChecksProperties is incompatible for future changes (e.g. #51), so this PR migrates to AbstractStatusChecksProperties (although the default method can be used, since the implementation is still in our control, we'd better refactor it).

In order to make the migration smooth without breaking the compatibility (if necessary), here is the plan or some steps for it:

  1. deprecate the StatusChecksProperties interface and add the AbstractStatusChecksProperties class (this PR)
  2. change BuildStatusChecksPublisher to allow it accepts implementations for both the old interface and new abstract class
  3. release the checks api plugin with this PR
  4. refactor the GitHub implementation GitHubStatusChecksProperties to extend AbstractStatusChecksProperties
  5. release the github checks plugin with the refacotring in (4)
  6. wait for some time to ensure the updating by users and then remove StatusChecksProperties interface

@XiongKezhi XiongKezhi added the enhancement New feature or request label Dec 12, 2020
@XiongKezhi XiongKezhi self-assigned this Dec 12, 2020
@XiongKezhi XiongKezhi added chore and removed enhancement New feature or request labels Dec 21, 2020
@XiongKezhi XiongKezhi merged commit 3ca4e19 into master Dec 21, 2020
@XiongKezhi XiongKezhi deleted the add_abstract_properties_class branch December 21, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants