Ensure we always call getContext().onFailure() in stop

[mrginglymus]

No description provided.

[codecov]

Codecov Report

Merging #73 (8215be6) into master (629cd7e) will decrease coverage by 0.18%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     87.23%   87.05%   -0.19%     
  Complexity       86       86              
============================================
  Files            15       15              
  Lines           478      479       +1     
  Branches         24       25       +1     
============================================
  Hits            417      417              
- Misses           54       55       +1     
  Partials          7        7              

Impacted Files	Coverage Δ	Complexity Δ
...o/jenkins/plugins/checks/steps/WithChecksStep.java	75.58% <16.66%> (-0.89%)	2.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629cd7e...8215be6. Read the comment docs.

[timja]

@mrginglymus have you tested this fixes your issue? or you want to deploy the incremental for a bit?

[mrginglymus]

I'll chuck the incremental on and see how it goes. Seems to repro fairly reliably. It'd be nice to test it, but I'm not sure how best to do that.

[mrginglymus]

It seems like I need to run a job and abort it externally - do we have a pattern for that?

[timja]

I'll chuck the incremental on and see how it goes. Seems to repro fairly reliably. It'd be nice to test it, but I'm not sure how best to do that.

not needed imo

[mrginglymus]

Initial impressions suggest that yes, this has fixed the issue.