show a progress bar to inform end-user about the current status #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
@ydubreuil please review |
|
ah nice improvement! |
ydubreuil
approved these changes
Sep 29, 2017
|
beautiful ! |
|
@aheritier I should also have a look at https://issues.jenkins-ci.org/browse/JENKINS-30669 and offer an estimate completion time, à la Windows "Disk usage computation in progress. Estimate duration: 256h" |
|
:-) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As computation can take long time, end user might stay waiting for computation without feedback on actual progress, getting nervous and start hitting the "refresh" button dozen times.
This PR introduce a progress bar (html5 browser required) to give him some visual feedback