Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-64854] Fix encoding for emails in CC #95

Merged
merged 1 commit into from
Mar 9, 2021
Merged

[JENKINS-64854] Fix encoding for emails in CC #95

merged 1 commit into from
Mar 9, 2021

Conversation

aheritier
Copy link
Member

JENKINS-64854 Use URLEncode for cc parameter

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
    - [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@aheritier aheritier self-assigned this Mar 7, 2021
@aheritier aheritier added the bug label Mar 7, 2021
@aheritier aheritier changed the title [JENKINS-64854] Correctly encode URL parameters [JENKINS-64854] Fix parameters encoding for emails in CC Mar 7, 2021
@aheritier aheritier changed the title [JENKINS-64854] Fix parameters encoding for emails in CC [JENKINS-64854] Fix encoding for emails in CC Mar 7, 2021
PierreBtz
PierreBtz approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the warning log message could be improved but it will never trigger so...

src/main/java/com/cloudbees/jenkins/plugins/advisor/utils/EmailUtil.java Outdated Show resolved Hide resolved
@aheritier aheritier merged commit e511443 into jenkinsci:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreBtz PierreBtz PierreBtz approved these changes

@Dohbedoh Dohbedoh Dohbedoh approved these changes

@kwhetstone kwhetstone Awaiting requested review from kwhetstone kwhetstone is a code owner

Assignees

@aheritier aheritier

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aheritier @Dohbedoh @PierreBtz