-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71414] Add DataBoundConstructor and Symbol to FolderConfigFileProperty #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecharp
changed the title
[JENKINS-71414] Add DataboundConstructor and remove un-necessary owne…
[JENKINS-71414] Compatibility with configuration-as-code
Jun 8, 2023
Would it be possible to test this automatically? |
rsandell
reviewed
Jun 13, 2023
src/main/java/org/jenkinsci/plugins/configfiles/folder/FolderConfigFileProperty.java
Outdated
Show resolved
Hide resolved
Last time I checked JCasC didn't support creating folders and other Items, so the title isn't really correct. |
Co-authored-by: Robert Sandell <rsandell@cloudbees.com>
jtnord
reviewed
Jun 15, 2023
src/main/java/org/jenkinsci/plugins/configfiles/folder/FolderConfigFileProperty.java
Outdated
Show resolved
Hide resolved
Dohbedoh
changed the title
[JENKINS-71414] Compatibility with configuration-as-code
[JENKINS-71414] Add DataBoundConstructor and Symbol to FolderConfigFileProperty
Jun 19, 2023
rsandell
approved these changes
Jun 27, 2023
rsandell
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still approved just don't merge this yet.Other things in the pipeline that needs to go in first.
rsandell
approved these changes
Jul 11, 2023
car-roll
pushed a commit
to car-roll/config-file-provider-plugin
that referenced
this pull request
Jul 24, 2023
…leProperty (jenkinsci#277) Co-authored-by: Robert Sandell <rsandell@cloudbees.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r overload
FolderConfigFileProperty
folderConfigFile
to the property descriptorowner
overload that is un-necessaryTesting done
--> Validate the the config files are still there after save
--> Validate the the config files are still there after restart
create a pipeline job in the folder:
Run the pipeline
--> Validate that it properly injects the file and the content is expected
Submitter checklist