Remove dependency exclusions #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency resolves successfully without the exclusion and no additional components are included in the hpi file after the change compared to before the change.
When this plugin requires Jenkins 2.387.3 or newer, it will be able to remove the explicit definition of the maven plugin version. The maven plugin is included in recent releases of bom-2.387.x and later.
alecharp
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency exclusions
The two exclusions that are included in the plugin test dependencies can be removed without harming the plugin and without failing any tests.
Testing done
Confirmed automated tests pass on my Linux computer with Java 11.0.20.1 and with Java 21-beta+34-202308082331.
Will rely on ci.jenkins.io to confirm tests pass on Windows.
Submitter checklist