Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73895] Remove inline onClick in ManagedFile/config.jelly #343

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

shlomomdahan
Copy link
Contributor

JENKINS-73895

The method called using the inline onClick no longer exists. It was replaced with form validation several years ago:

e76f2e5

Everything works as it did originally as the onClick had no functionality.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan shlomomdahan requested a review from a team as a code owner October 20, 2024 19:57
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil added the internal label Oct 22, 2024
@basil basil changed the title [JENKINS-73895] Remove inline onClick in ManagedFile/config.jelly - obsolete method [JENKINS-73895] Remove inline onClick in ManagedFile/config.jelly Oct 22, 2024
@basil basil merged commit 4554bc6 into jenkinsci:master Oct 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants