Fix anonymous class serialization warnings #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config files for the new test have been set up as similar as possible to the existing one, only ids differ. The existing test was cleaned a bit.
Anonymous inner classes are replaced by a dedicated comparator class. NOTE: Also introducing classes to keep XStream backward compatibility. This was missed in the previous attempt in commit 2366eae. The warnings from org.jenkinsci.remoting.util.AnonymousClassWarnings have been: > "Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.configfiles.GlobalConfigFiles$1 ..." > "Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.configfiles.folder.FolderConfigFileProperty$1 ..." see: https://wiki.jenkins.io/display/JENKINS/Serialization+of+anonymous+classes
|
@imod can you prepare a new release containing this? |
|
@imod Sorry to bother you again, could you release this? |
|
@darxriggs done - sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings from org.jenkinsci.remoting.util.AnonymousClassWarnings have been:
See https://wiki.jenkins.io/display/JENKINS/Serialization+of+anonymous+classes for more details on this topic.
There have already been other attempts to fix these warnings in c95c3dd and d6616d7. It was reported in JENKINS-53399 that XStream backward compatibility was broken. Therefore they have been reverted in fab4484.
This change also keeps XStream backward compatibility.
CC @jsoref