Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It has been renamed to master.componentName #1256

Merged
merged 6 commits into from
Feb 1, 2020
Merged

It has been renamed to master.componentName #1256

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f18dd60
it has been renamed to `master.componentName`
jhonmike Jan 24, 2020
37af68c
remove name flag in helm 3
jhonmike Jan 24, 2020
cdb1407
updated the parameters based on the official chart configuration
jhonmike Jan 24, 2020
1818fb3
Update demos/kubernetes-helm/README.md
Jan 24, 2020
1f31fe0
Update demos/kubernetes-helm/README.md
Jan 24, 2020
873e0b6
update demo template helm
jhonmike Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions demos/kubernetes-helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@ The latest stable helm chart can be found [here](https://github.com/helm/charts/
Now grab a copy of the helm chart [values file](https://github.com/helm/charts/blob/master/stable/jenkins/values.yaml) and adjust the Master part a little bit:

```yaml
Master:
Name: jenkins-master
Image: "jenkins/jenkins"
ImageTag: "2.134-alpine"
ImagePullPolicy: "IfNotPresent"
Component: "jenkins-master"
master:
componentName: jenkins-master
Image: 'jenkins/jenkins'
jhonmike marked this conversation as resolved.
Show resolved Hide resolved
ImageTag: '2.134-alpine'
ImagePullPolicy: 'IfNotPresent'
Component: 'jenkins-master'
UseSecurity: true
AdminUser: admin
AdminPassword: "formetoknowforyoutofindout"
Cpu: "200m"
Memory: "1024Mi"
AdminPassword: 'formetoknowforyoutofindout'
Cpu: '200m'
Memory: '1024Mi'

# Below is the implementation of Jenkins Configuration as Code. Add a key under ConfigScripts for each configuration area,
# where each corresponds to a plugin or section of the UI. Each key (prior to | character) is just a label, and can be any value.
Expand Down Expand Up @@ -93,7 +93,7 @@ Master:
Now, deploy the Helm chart with those customized values:

```bash
helm install --name jenkins stable/jenkins -f values.yaml
helm install jenkins stable/jenkins -f values.yaml
```

Once Helm finishes deploying the chart, connect to your Jenkins server in your browser. You should see the welcome system message displayed at the top. Congratulations, you've installed the plugin and made your first Jenkins configuration change successfully! :)
Expand Down
4 changes: 2 additions & 2 deletions demos/kubernetes-helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
# Declare name/value pairs to be passed into your templates.
# name: value

Master:
Name: jenkins-master
master:
componentName: jenkins-master
Image: "jenkins/jenkins"
jhonmike marked this conversation as resolved.
Show resolved Hide resolved
ImageTag: "lts"
ImagePullPolicy: "Always"
Expand Down