drop yui button

[scherler]

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[mPokornyETM]

@scherler might you pls provide screenshot before && after. thx

[scherler]

@mPokornyETM, can you point me to how to do that? I am not sure how to reach the src/main/resources/Hudson/plugins/copy artifact/monitor/LegacyJobConfigMigrationMonitor/manage.jelly. Could you please outline how to see it? I applied the same classes to fix other (similar) use cases.

[Amankkc]

@scherler Please try to add some border to enhance the "RESET" Button effect and making it look close to the existing one.

[mPokornyETM]

@scherler Please try to add some border to enhance the "RESET" Button effect and making it look close to the existing one.

I am not sure, if it is good idea. To eliminate effort, it will be better to use jenkins style only. You will be sure. it works with all other plugins / styles / themes / dark mode ... together. From my side I will also try to remove all the custom css files like:
https://github.com/scherler/copyartifact-plugin/blob/drop_yui_button/src/main/resources/hudson/plugins/copyartifact/monitor/LegacyJobConfigMigrationMonitor/resources.css

from my POW it will be fine to replace jenkins-tab by dataTable plugin. It allows many cool features.
But all of them is not necessary to do in this PR

[scherler]

@Amankkc I created jenkinsci/jenkins#10061 however I agree with @mPokornyETM to not introduce custom css

[scherler]

For what is worth I can drop https://github.com/scherler/copyartifact-plugin/blob/drop_yui_button/src/main/resources/hudson/plugins/copyartifact/monitor/LegacyJobConfigMigrationMonitor/resources.css#L46-L58 if you @mPokornyETM want

[mPokornyETM]

For what is worth I can drop

my proposal is to merge this change as is, and provide other PR to remove the legacy css changes.

[mPokornyETM]

LGTM