Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced MaskingOutputStream to DRY between Pipeline & freestyle #139

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Introduced MaskingOutputStream to DRY between Pipeline & freestyle #139

merged 3 commits into from
Jun 23, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 23, 2021 •
edited
Loading

Also allows this new utility, and the existing getAggregateSecretPattern, to be consumed from other plugins: #59 (comment)

@jglick jglick added the chore label Jun 23, 2021
@jglick jglick enabled auto-merge June 23, 2021 16:40
@jglick jglick disabled auto-merge June 23, 2021 16:43
@jglick jglick added enhancement and removed chore labels Jun 23, 2021
@jglick
Copy link
Member Author

jglick commented Jun 23, 2021

From a GitHub text search on LineTransformationOutputStream I actually found a lot of plugins which could benefit from this. Going to file some PRs and some issues.

This was referenced Jun 23, 2021
Merged
Merged
Merged
@jglick jglick merged commit 615d236 into jenkinsci:master Jun 23, 2021
@jglick jglick deleted the MaskingOutputStream branch June 23, 2021 20:49
jglick added a commit to jglick/kubernetes-plugin that referenced this pull request Jun 23, 2021
@jglick
jenkinsci/credentials-binding-plugin#139 released
6758629
jglick added a commit to jglick/pipeline-maven-plugin that referenced this pull request Jun 23, 2021
@jglick
jenkinsci/credentials-binding-plugin#139 released
50a8856
jglick added a commit to jglick/azure-keyvault-plugin that referenced this pull request Jun 23, 2021
@jglick
jenkinsci/credentials-binding-plugin#139 released
decf4ba
@jglick
Copy link
Member Author

jglick commented Jun 23, 2021

https://issues.jenkins.io/browse/JENKINS-65972 https://issues.jenkins.io/browse/JENKINS-65973 https://issues.jenkins.io/browse/JENKINS-65974 https://issues.jenkins.io/browse/JENKINS-65975 https://issues.jenkins.io/browse/JENKINS-65976

timja pushed a commit to jenkinsci/azure-keyvault-plugin that referenced this pull request Jun 24, 2021
@jglick
Use SecretPatterns from MaskingConsoleLogFilter (#84)
1aba71c 
* Use `SecretPatterns` from `MaskingConsoleLogFilter`

* jenkinsci/credentials-binding-plugin#139 released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer abayer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @abayer