Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listDependenciesFromPom failed to include test-scoped plugin dependencies #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 8, 2019

…as promised in the documentation:

If the pom option is set, all dependencies will be added, including test ones.

I think this regressed in #35.

Also its technique of skipping dependencies with classifiers did not account for, say, core-assets.

@oleg-nenashev
Copy link
Member

This is a case when we might need to adjust documentation to the reality. Needs input from @raul-arabaolaza

Also its technique of skipping dependencies with classifiers did not account for, say, core-assets.

Please create a ticket for that

@jglick
Copy link
Member Author

jglick commented Jul 9, 2019

OK, I might just skip CWP and rebuild a WAR manually…might actually be easier than getting this patch in.

@jglick
Copy link
Member Author

jglick commented Jul 9, 2019

Seems to be a build failure in test_war_from_pom_with_timeout; have not yet looked at what that means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants