Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin Group IDs optional in the YAML specification #171 #243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

natsen
Copy link

@natsen natsen commented Nov 15, 2022

  • Added UpdateCenterPluginInfoProvider.getGroupId(String artifactId) to use the groupIdCache and fetch the groupId

  • In DependencyInfo using PluginInfoProvider.getGroupId(artifactId) to fetch groupId. groupId field is now optional when Update Center Plugin plugin info Provider s used, which is the default.

  • Updated sample.yml to include a plugin without groupId for test coverage.
    Link to Github issue: Make plugin Group IDs optional in the YAML specification #171

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!

  • Ensure that the pull request title represents the desired changelog entry

  • Please describe what you did

  • Link to relevant issues in GitHub or Jira

  • Link to relevant pull requests, esp. upstream and downstream changes

  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@natsen natsen marked this pull request as draft November 15, 2022 04:49
@natsen
Copy link
Author

natsen commented Nov 16, 2022

The build and tests are passing locally. The failing checks are unrelated to the change in this PR. I observe the previous PR's were also failing similarly. I could not figure out why. Can someone help fix the existing master so this PR can pass the checks.

[INFO] Reactor Summary for Jenkins Custom WAR Packager Parent POM 2.0-alpha-7-SNAPSHOT: [INFO] [INFO] Jenkins Custom WAR Packager Parent POM ............. SUCCESS [ 1.363 s] [INFO] Jenkins Custom WAR Packager Library ................ SUCCESS [ 5.948 s] [INFO] Jenkins Custom WAR Packager CLI .................... SUCCESS [ 20.060 s] [INFO] Jenkins Custom WAR Packager Maven Plugin ........... SUCCESS [01:43 min] [INFO] Integration tests for Custom war Packager and Jenkinsfile Runner SUCCESS [16:03 min] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18:14 min [INFO] Finished at: 2022-11-15T18:17:26-08:00 [INFO] ------------------------------------------------------------------------

@natsen natsen marked this pull request as ready for review November 16, 2022 02:20
@natsen
Copy link
Author

natsen commented Nov 22, 2022

@oleg-nenashev this is my first PR. can you suggest if there is anything I can help with to get this PR through.

@natsen
Copy link
Author

natsen commented Feb 7, 2023

@oleg-nenashev can you let me help fix this issue with the CI that is blocking my PR

@oleg-nenashev
Copy link
Member

I am cleaning up the code in another branch. But yes, let's try to get it landed

@natsen
Copy link
Author

natsen commented Apr 6, 2023

any updates. anything I can do to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants