Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to refresh statsd client when the host's IP has changed #276

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

sarah-witt
Copy link
Collaborator

@sarah-witt sarah-witt commented Feb 15, 2022

What does this PR do?

Adds an option to refresh the statsd client when the hostname's IP changed

Description of the Change

When the option is enabled, the agent client will first check if the IP has changed since the last metric submission, if it has, then it will update the IP and re-initialize the statsd client

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt sarah-witt changed the title Add option to refresh statsd client Add option to refresh statsd client when the host Feb 15, 2022
@sarah-witt sarah-witt changed the title Add option to refresh statsd client when the host Add option to refresh statsd client when the host's IP has changed Feb 15, 2022
@sarah-witt sarah-witt added the changelog/Added Added features results into a minor version bump label Feb 15, 2022
@sarah-witt sarah-witt marked this pull request as ready for review February 15, 2022 16:11
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sarah-witt sarah-witt merged commit a9af57a into master Feb 22, 2022
@sarah-witt sarah-witt deleted the sarah/re-initialize-statsd-connection branch February 22, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants