Add is_manual field to pipelines #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ protected String getNodeName(Run<?, ?> run, BuildData buildData, BuildData updat | |||
| return buildData.getNodeName("").isEmpty() ? updatedBuildData.getNodeName("") : buildData.getNodeName(""); | |||
| } | |||
|
|
|||
| protected String getNodeHostname(Run<?, ?> run, BuildData updatedBuildData) { | |||
| static protected String getNodeHostname(Run<?, ?> run, BuildData updatedBuildData) { | |||
There was a problem hiding this comment.
I thought this would be better since these functions don't really use any non-static members from to class. In C# it's actually a good practice and it makes things faster. If this is uncommon, confusing or not a good practice in Java let me know and I can revert.
src/test/java/org/datadog/jenkins/plugins/datadog/listeners/DatadogGraphListenerTest.java
Outdated
Show resolved
Hide resolved
albertvaka
force-pushed
the
albertvaka/add-is-manual
branch
from
78d5759
to
4fa7fa5
Compare
drodriguezhdez
approved these changes
Mar 7, 2023
albertvaka
added
the
changelog/Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
is_manualfield that is true when aRuncontains aUserIdCause.Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.