Set hpi.compatibleSinceVersion to 1.0.0 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianVeaux
requested review from
bkabrda,
gzussa,
jirikuncar,
nmuesch and
zippolyte
as code owners
FlorianVeaux
added
the
changelog/Fixed
ChristineTChen
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
hpi.compatibleSinceversion=1.0.0to the plugin pom.xml.This field allows Jenkins to show a warning upon installtion.
More details here: https://wiki.jenkins.io/display/JENKINS/Marking+a+new+plugin+version+as+incompatible+with+older+versions
Version 1.0.0 introduced breaking changes but none since then.
Couldn't check if the warning is present, as it'll only show up once deployed to the maven repo.
Additional Notes
Opening a PR from a fork as I'm still waiting on getting access to the repo from the jenkins team.
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.