Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add_note_about_filled_buttons] add note and example for filled button #360

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

scherler
Copy link

image

Added example for filled button

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Signed-off-by: Thorsten Scherler <scherler@gmail.com>
@timja
Copy link
Member

timja commented Dec 17, 2024

(conflicts)

@janfaracik
Copy link
Contributor

Heya. Any thoughts on #370 instead? Just a small change compared to yours but I think it gives an example of when you might use said modifiers, e.g. for building or deleting.

@scherler
Copy link
Author

@janfaracik left a comment there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants