Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-61409] - Update to Remoting 4.3 for WebSocket large payload fix. #110

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

jeffret-b
Copy link
Contributor

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just have

ARG VERSION

and then specify the actual version just once in Makefile.

@jeffret-b
Copy link
Contributor Author

Jesse has a great idea. Do you or someone on the team want to implement that? Or I could see about putting something together.

@jeffret-b
Copy link
Contributor Author

See if we can get clean rebuild.

@jeffret-b jeffret-b closed this Mar 26, 2020
@jeffret-b jeffret-b reopened this Mar 26, 2020
@oleg-nenashev
Copy link
Member

Jesse has a great idea. Do you or someone on the team want to implement that? Or I could see about putting something together.

We still use the DockerHub Autobuild as a delivery engine. One we move to the Jenkins release environment, we can change the implementation

@jeffret-b
Copy link
Contributor Author

Looks like some timeout in the build.

@MarkEWaite
Copy link
Contributor

It is looking for an agent with the label windock. There is only one agent with that label currently. It is https://ci.jenkins.io/computer/win2019-a7d1c0/ and it is offline

@slide I'm not clear on the ci.jenkins.io agent labels for Windows machines. I assume windock means a Windows machine that has Docker for Windows installed. Is it also assumed that label means the Windows machine can run Windows Docker images (as opposed to Linux images)?

@slide
Copy link
Member

slide commented Mar 26, 2020

@MarkEWaite, yes there are two different Windows images because most plugins assume Linux when running on an agent with the docker label, also the image is larger when it has docker installed because there is no Windows Server Core sku with docker on Azure.

@slide
Copy link
Member

slide commented Mar 26, 2020

It's only been running for 7 minutes so far, the Windows agents can take some time to spin up, so this time doesn't see out of the ordinary.

@slide slide merged commit e1d910a into jenkinsci:master Mar 27, 2020
@oleg-nenashev oleg-nenashev changed the title Update to Remoting 4.3 for WebSocket large payload fix. [JENKINS-61409] - Update to Remoting 4.3 for WebSocket large payload fix. Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants