Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Debian images to Buster by default #119

Merged
merged 4 commits into from
Apr 11, 2020
Merged

Conversation

oleg-nenashev
Copy link
Member

Follow-up to #105 by @krufab. The change adds Debian Buster image and switches both Java 8 and Java 11 images to Buster.

Copy link
Member

@slide slide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, otherwise looks good

Makefile Outdated
build-debian-buster:
docker build -t ${IMAGE_NAME}:latest \
-t ${IMAGE_NAME}:jdk8 \
-t ${IMAGE_NAME}:jdk8-buster \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indenting issue

Makefile Outdated
-t ${IMAGE_NAME_AGENT}:jdk11-buster \
11/buster/
-t ${IMAGE_NAME_AGENT}:jdk11-buster \
-t ${IMAGE_NAME_AGENT}:jdk11 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indenting issue

@oleg-nenashev
Copy link
Member Author

Docker CI is broken, will merge into the master to prepare the next release. Will fix CI after the repo renaming tomorrow

@oleg-nenashev oleg-nenashev merged commit d18176c into master Apr 11, 2020
@oleg-nenashev oleg-nenashev deleted the jdk8-buster branch April 13, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants