-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Debian images to Buster by default #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpicks, otherwise looks good
Makefile
Outdated
build-debian-buster: | ||
docker build -t ${IMAGE_NAME}:latest \ | ||
-t ${IMAGE_NAME}:jdk8 \ | ||
-t ${IMAGE_NAME}:jdk8-buster \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indenting issue
Makefile
Outdated
-t ${IMAGE_NAME_AGENT}:jdk11-buster \ | ||
11/buster/ | ||
-t ${IMAGE_NAME_AGENT}:jdk11-buster \ | ||
-t ${IMAGE_NAME_AGENT}:jdk11 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indenting issue
Docker CI is broken, will merge into the master to prepare the next release. Will fix CI after the repo renaming tomorrow |
Follow-up to #105 by @krufab. The change adds Debian Buster image and switches both Java 8 and Java 11 images to Buster.