Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buster: Remove stretch-backports from apt sources #137

Merged
merged 2 commits into from
May 13, 2020
Merged

Buster: Remove stretch-backports from apt sources #137

merged 2 commits into from
May 13, 2020

Conversation

Bomme
Copy link
Contributor

@Bomme Bomme commented May 13, 2020

stretch-backports was brought in by #61 to support the install of git-lfs which for buster is also in stable

stretch-backports was brought in by #61 to support the install of git-lfs which for buster is also in stable
@Bomme Bomme requested a review from a team as a code owner May 13, 2020 15:50
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense that we not include stretch backports in the buster definition. The inclusion of stretch backports should not have been harmful, since same or newer versions are in the buster repository, but there is no reason to confuse the packaging with a source that does not provide useful packages.

Thanks for detecting the problem!

Also needs the change to remove the reference to stretch-backports when installing git-lfs. In other images, we've had to use specific steps to install a newer Git LFS than was available from stretch-backports. See https://github.com/jenkinsci/docker/blob/b3fe176b868c9510e5c978c8bb8b3380281b3ca9/Dockerfile#L3 . I am not sure if that will be needed here or not. Will depend on the version of git LFS provided with Debian Buster.

8/buster/Dockerfile Outdated Show resolved Hide resolved
@slide slide merged commit 02166f5 into jenkinsci:master May 13, 2020
@Bomme Bomme deleted the patch-1 branch May 14, 2020 12:24
@oleg-nenashev oleg-nenashev changed the title Remove stretch-backports from apt sources Buster: Remove stretch-backports from apt sources Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants