Added alpine tags with OS version (i.e. alpine3.15) #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Kruger <10956489+krufab@users.noreply.github.com>
timja
reviewed
Jan 15, 2022
timja
reviewed
Jan 15, 2022
| @@ -78,8 +86,11 @@ target "alpine_jdk8" { | |||
| } | |||
| tags = [ | |||
There was a problem hiding this comment.
Missing passing the alpine build arg above
timja
approved these changes
Jan 15, 2022
timja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Kruger 10956489+krufab@users.noreply.github.com
Updated docker-back.hcl to create new tags for the alpine target containing the alpine OS release as well (i.e. alpine3.15-jdk11).
Archlinux was not changed as they have a fast release cycle, while debian bullseye is already a (named) version.
Fixes #227