Switch Alpine base image to official eclipse-temurin #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
timja
approved these changes
Apr 26, 2022
MarkEWaite
changed the title
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switched the base image of the Alpine agents (JDK8, JDK11 and JDK17) from the stock "Alpine" to the official "eclipse-temurin" alpine variant.
It has the following benefits:
Strict control of the JDK used, to control the version, as we were using the "latest" version as per the usual Alpine package manager style. "Latest" version is fine for some tools like
ca-certificates, but in the case of the JDK, it is important to know which version is used or not.Faster and simplified builds for JDK11 and JDK17. We were using
jlinkto generate a custom JVM installation compliant withmuslas no eclipse temurin Alpine image was available back then. It was convenient but being able to use the "stock" installation simplifies the Dockerfiles.Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
[ ] Link to relevant issues in GitHub or Jira[ ] Link to relevant pull requests, esp. upstream and downstream changesEnsure you have provided tests - that demonstrates feature works or fixes the issue