Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm32 images to the build #260

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Add arm32 images to the build #260

merged 3 commits into from
Jul 5, 2022

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Jul 4, 2022 •
edited by MarkEWaite
Loading

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

I added linux/arm/v7 to debian_jdk11 and debian_jdk17 on the docker-bake.hcl file.
I also had to make a change in 17/bullseye/Dockerfile because it wouldn't build by cause of a jmods: Value too large for defined data type error.

It now builds correctly for me when issuing:

docker buildx bake -f docker-bake.hcl debian_jdk11

or

docker buildx bake -f docker-bake.hcl debian_jdk17

@gounthar
Build does not work for linux/arm/v7
db10873 
When doing `docker buildx bake -f docker-bake.hcl debian_jdk17` we get

```bash
[linux/arm/v7 jre-build 2/2] RUN jlink          --add-modules ALL-MODULE-PATH          --strip-java-debug-attributes          --no-man-pages          --no-header-files          --compress=2          --output /javaruntime:
#0 4.256 Error: java.nio.file.FileSystemException: /opt/java/openjdk/jmods: Value too large for defined data type
```

I found this [reference](docker/buildx#395 (comment)) which indicates we could use `--platform=$BUILDPLATFORM` to avoid this error.
@gounthar
Adding arm32 to Debian JDK11 and Debian JDK17.
7db7661
@gounthar
Create linux-arm32 group.
9cd5d2e
@timja
Copy link
Member

timja commented Jul 4, 2022

Looks fine, although I'm curious which devices are using arm32 and Jenkins? Raspberry PIs?

@gounthar
Copy link
Contributor Author

gounthar commented Jul 4, 2022 •
edited
Loading

Looks fine, although I'm curious which devices are using arm32 and Jenkins? Raspberry PIs?

Thanks Tim.

"Old" 32 bits Raspberry Pis and also more recent Raspberry Pis which are still running a 32 bits Raspbian version (like the 3B+ for example), why not...

But also more powerful and more recent boards like the Odroid XU4 (HC2/MC1),
the SolidRun ClearFog (2 A9 cores, 1GB/8GB eMMC, M.2),
the HummingBoard Edge,
the Jetson TK1,
the Compulab Utilite Pro,
the AM5718,
the SBC-iMX6 and so on...

@gounthar gounthar marked this pull request as ready for review July 4, 2022 14:43
@gounthar gounthar requested a review from a team as a code owner July 4, 2022 14:43
MarkEWaite
MarkEWaite approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Thanks!

@timja timja merged commit 63c77f7 into jenkinsci:master Jul 5, 2022
@gounthar gounthar deleted the armhf branch July 5, 2022 07:31
@carpnick carpnick mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gounthar @timja @MarkEWaite