chore: fix hadolint/shellcheck violations #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
… tag (tracked by dependabot) Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
timja
approved these changes
Nov 12, 2022
dduportal
force-pushed
the
chore/hadolint
branch
from
7bb0a3f
to
120dee9
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…l chars Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
chore/hadolint
branch
from
14f8985
to
c06df26
Compare
|
Possible cause of JENKINS-70157? Of all the commits I looked through between 3071.v7e9b_0dc08466-1 and 3071.v7e9b_0dc08466-5 this seemed like the most likely candidate. CC @dduportal |
That could also be impacting ci.jenkins.io. Currently checking, thanks for the notice @basil |
|
I can't reproduce the issue on my Windows setup any help is welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a set of hadolint/shellcheck violations on the images.
Tried to proceed 1 commit per rule, so we can easily rollback only one.
I'm not sure yet how to efficiently load hadolint recursively on ALL
Dockerfilethough.