Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debian) Add missing packages to allow git cloning by ssh #326

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Nov 16, 2022

With the help of @dduportal I added the minimal list of packages that are needed to be able to clone via ssh for the Debian image.
It's an attempt to solve #322.

Current situation

The list of packages brought by installing git is:

git-man libcurl3-gnutls liberror-perl libgdbm-compat4 libgdbm6 libperl5.32 perl perl-modules-5.32

We're missing at least openssh-client .

Before regression

The list of packages brought by installing git was:

git-man less libbsd0 libcbor0 libcurl3-gnutls libedit2 liberror-perl libfido2-1 libgdbm-compat4 libgdbm6 libmd0 libperl5.32 libx11-6 libx11-data libxau6 libxcb1 libxdmcp6 libxext6 libxmuu1 netbase openssh-client patch perl perl-modules-5.32
  xauth

What should be added

openssh-client patch less netbase

Tests

We added two tests which try to find the ssh binary thanks to command -v and then launch ssh -V to get the ssh version and a 0 return code.

By the way, it also showed that the ArchLinux image was failing that test, so we added the openssh package too for this Dockerfile.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dduportal dduportal added the bug label Nov 16, 2022
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gounthar gounthar marked this pull request as ready for review November 16, 2022 13:52
@gounthar gounthar requested a review from a team as a code owner November 16, 2022 13:52
@dduportal dduportal merged commit 81f6c29 into jenkinsci:master Nov 16, 2022
@gounthar gounthar deleted the fix-gh-322 branch November 16, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants