-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(documentation) Adds a small paragraph describing how to use another timezone #338
Conversation
…her timezone By default, the image is using `Etc/UTC`.
Not blocking, but maybe suggesting mounting the host For instance, from the jenkinsci/docker-inbound-agent#337 (with tzdata installed)
and
|
…ebuilding an image Thanks a lot Damien for taking the time to review, test and make proposals. jenkinsci#338 (comment)
`TIME_ZONE` is not.
`TIME_ZONE` is not.
Including it into curly braces and double quotes as suggested by Damien.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nitpicks suggestion feel free to accept or refuse them.
Otherwise it's nice, thanks!
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Thanks a lot for the review, I always forget about those long flags. 😊 |
By default, the image is using
Etc/UTC
. A user wants to use another timezone (c.f. #291.I explain briefly how to use another one while creating a new image derived from
jenkins/agent
.This is a follow-up to jenkinsci/docker-inbound-agent#337 where I added the
tzdata
package.This PR and the jenkinsci/docker-inbound-agent#337 will replace my first attempt (see jenkinsci/docker-inbound-agent#334).
Ensure you have provided tests - that demonstrates feature works or fixes the issue