Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alpine) Alpine 3.17 tzdata package doesn't contain zdump anymore #344

Merged

Conversation

gounthar
Copy link
Contributor

With the latest (#341 #342 and #343) the tests regarding tzdata failed for Alpine Linux:

jenkinsci.docker.alpine_jdk11.Default.#8 [docker.io/jenkins/agent:alpine] 'tzdata' is correctly installed
jenkinsci.docker.alpine_jdk17.Default.#8 [docker.io/jenkins/agent:alpine-jdk17] 'tzdata' is correctly installed

In the Dockerfile we build the image from eclipse-temurin:11.0.17_8-jdk-alpine. This version now uses Alpine 3.17 and no more 3.16.

In Alpine 3.16 the tzdata package used to contain the zdump binary we're using in our tests.
In Alpine 3.17 it has moved to the tzdata-utils package.

When this is merged, it should allow #341 #342 and #343 to build.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar marked this pull request as ready for review December 12, 2022 14:20
@gounthar gounthar requested a review from a team as a code owner December 12, 2022 14:20
@dduportal
Copy link
Contributor

@gounthar Don't forget to also update 17/alpine :)

@gounthar
Copy link
Contributor Author

There you go. 😊

@dduportal dduportal added the bug label Dec 12, 2022
@dduportal dduportal merged commit d51029c into jenkinsci:master Dec 12, 2022
@gounthar gounthar deleted the alpine-3.17-tzdata-does-not-contain-zdump branch December 12, 2022 15:44
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 27, 2023
…ix-test-harness

chore(windows tests) improve harness (`docker` flags and commands)
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 11, 2024
…ix-test-harness

chore(windows tests) improve harness (`docker` flags and commands)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants