-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jdk21-preview): correct JAVA_MAJOR_VERSION
extraction for the EA release link
#538
Conversation
21
in the repo name of the EA release link21
in the repo name of the EA release link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Either you need to hardcode the 2nd occurence of
JAVA_MAJOR_VERSION
and remove all occurences (and the definition) - Or eventually use my suggestion by fixing the
JAVA_MAJOR_VERSION
definition
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
21
in the repo name of the EA release linkJAVA_MAJOR_VERSION
extraction for the EA release link
Hum... It failed on the primary branch 🤔 https://github.com/jenkinsci/docker-agent/actions/runs/6624130432/job/17992491585
|
Ran the action again without any issue 🤷 |
This PR fixes the preview (EA) release download link in the Dockerfile of the debian_jdk_21_preview image.
Related: #537
Testing done
Submitter checklist