Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jdk21-preview): correct JAVA_MAJOR_VERSION extraction for the EA release link #538

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

lemeurherve
Copy link
Member

This PR fixes the preview (EA) release download link in the Dockerfile of the debian_jdk_21_preview image.

Related: #537

Testing done

Submitter checklist

@lemeurherve lemeurherve requested a review from a team as a code owner October 23, 2023 08:43
@lemeurherve lemeurherve changed the title fix(jdk21-preview): hardcoding 21 in the repo name of the EA release link fix(jdk21-preview): hardcode 21 in the repo name of the EA release link Oct 23, 2023
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong link:
https://github.com/adoptium/temurin21.0.1-binaries/releases/download/jdk-21.0.1%2B12-ea-beta/OpenJDK21.0.1U-jdk_s390x_linux_hotspot_ea_21-0-1-12.tar.gz

Correct link:
https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.1%2B12-ea-beta/OpenJDK21U-jdk_s390x_linux_hotspot_ea_21-0-1-12.tar.gz

  • Either you need to hardcode the 2nd occurence of JAVA_MAJOR_VERSION and remove all occurences (and the definition)
  • Or eventually use my suggestion by fixing the JAVA_MAJOR_VERSION definition

debian/preview/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve changed the title fix(jdk21-preview): hardcode 21 in the repo name of the EA release link fix(jdk21-preview): correct JAVA_MAJOR_VERSION extraction for the EA release link Oct 23, 2023
@lemeurherve lemeurherve changed the title fix(jdk21-preview): correct JAVA_MAJOR_VERSION extraction for the EA release link fix(jdk21-preview): correct JAVA_MAJOR_VERSION extraction for the EA release link Oct 23, 2023
@lemeurherve lemeurherve requested review from dduportal and a team October 23, 2023 13:22
@lemeurherve lemeurherve merged commit 2bbe69f into master Oct 24, 2023
11 checks passed
@lemeurherve lemeurherve deleted the lemeurherve-patch-1 branch October 24, 2023 08:13
@lemeurherve
Copy link
Member Author

Hum... It failed on the primary branch 🤔

https://github.com/jenkinsci/docker-agent/actions/runs/6624130432/job/17992491585

ERROR: something went wrong in target "setJDK21PreviewVersionDockerBake" : "command error on refs/heads/updatecli_39548d6bb0215e91203e5365849207b3faf5504376b23ab629f00709c4208dd3: refusing to allow a GitHub App to create or update workflow .github/workflows/release-drafter.yml without workflows permission"

@lemeurherve
Copy link
Member Author

lemeurherve commented Oct 24, 2023

Ran the action again without any issue 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants