Add -noReconnectAfter option support

[Vlatombe]

• Downstream of Add -noReconnectAfter option remoting#738

Testing done

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jglick]

Do we really need this? I feel like we should deprecate the env vars in this launcher script except for one catch-all REMOTING_OPTS var with whatever CLI options you like; then https://github.com/jenkinsci/kubernetes-plugin/blob/f10083a42e708a6bff990c6ccb306ce618b8bccd/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java#L415-L449 could (eventually, once adopted) be simplified to just construct its list of CLI options directly without needing to make further changes to this image beyond routine JAR bumps.

[dduportal]

Do we really need this? I feel like we should deprecate the env vars in this launcher script except for one catch-all REMOTING_OPTS var with whatever CLI options you like; then https://github.com/jenkinsci/kubernetes-plugin/blob/f10083a42e708a6bff990c6ccb306ce618b8bccd/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java#L415-L449 could (eventually, once adopted) be simplified to just construct its list of CLI options directly without needing to make further changes to this image beyond routine JAR bumps.

Good idea! Just be warned that there are other use cases of this launcher script AFAIK such as static agents or docker plugin for example.

[jglick]

Yes, and for compatibility we need to continue to support the currently defined variables, I am just suggesting that going forward we deprecate them in favor of a generic launcher options variable. Would also allow us to deprecate and eventually remove messy stuff like

docker-agent/jenkins-agent

Lines 60 to 61 in 611dc9d

	case "$@" in
	*"-workDir"*) echo "Warning: Work directory is defined twice in command-line arguments and the environment variable" ;;

docker-agent/jenkins-agent

Lines 131 to 132 in 611dc9d

	#TODO: Handle the case when the command-line and Environment variable contain different values.
	#It is fine it blows up for now since it should lead to an error anyway.

You can already pass any arguments you like to the entrypoint ("$@") but for purposes of some cloud impls like PodTemplateBuilder it is easier to set environment variables.

[Vlatombe]

I had forgotten about that, let's just close this.

[Vlatombe]

any arguments you like to the entrypoint

Only on linux, the windows launcher script is missing this option.

Filed #809 as a draft.