Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): Reformat readme tags #803

Merged
merged 7 commits into from
May 7, 2024

Conversation

itayporezky
Copy link
Contributor

@itayporezky itayporezky commented May 7, 2024

(Draft, see open questions below)

Background:

After using the docker agents for much time, i found i was actually using less optimal tags then the ones i randomly discovered in the dockerhub tag search

Description

  1. This is a reformatting of the readme to hopefully make the tags that are available to be used more clear.
  2. Also added 1 more tag in the bake file to align with the same amount of tags created on alpine and same format.
  3. Open questions:
  • which i thought about too late: Is there an actual need for so many JDK flavors?
  • Deprecate archlinux? released tags seem old

(I suggest to review using some Markdown previewer)
Related #777

Testing done

N/A

Submitter checklist

@itayporezky itayporezky requested a review from a team as a code owner May 7, 2024 19:52
@itayporezky itayporezky marked this pull request as draft May 7, 2024 19:55
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some general improvements, ideally tagged builds would be promoted in some way, they are quite far down and probably not as clear as they should be but I think this is better than before so approving.

@timja
Copy link
Member

timja commented May 7, 2024

Deprecate archlinux? released tags seem old

See #422

@itayporezky
Copy link
Contributor Author

Looks good for now :)

@itayporezky itayporezky marked this pull request as ready for review May 7, 2024 20:24
@timja timja merged commit de1d07f into jenkinsci:master May 7, 2024
10 checks passed
@timja
Copy link
Member

timja commented May 7, 2024

FWIW in case you are interested, inbound agent is in an even worse state with no mentioned tags
https://github.com/jenkinsci/docker-agent/blob/master/README_inbound-agent.md

https://hub.docker.com/r/jenkins/inbound-agent

@itayporezky itayporezky deleted the feat/update_readme branch May 8, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants