Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow running updatecli with --debug #806

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented May 14, 2024

This PR adds an input to the workflow_dispatch of the updatecli GitHub Action so we can use it to run updatecli with the --debug parameter.

Ref:

Testing done

Submitter checklist

@lemeurherve lemeurherve added chore github_actions Pull requests that update GitHub Actions code updatecli labels May 14, 2024
@lemeurherve lemeurherve requested a review from a team as a code owner May 14, 2024 22:02
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure (to confirm with @olbak) but doing so would risk exposing sensitive values such as the GitHub token so at first sight I'm not voting for this change.

Additionally, I don't understand why this would be helpful for #798 (comment) as the issue was regarding the shell script itself, not by updatecli.

@lemeurherve lemeurherve deleted the allow-run-updatecli-in-debug-mode branch May 15, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore github_actions Pull requests that update GitHub Actions code updatecli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants