Bugfix: Fix regression where environment variables set to USER would be lowercased to user. #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #858 |
dduportal
approved these changes
Aug 14, 2024
dduportal
requested changes
Aug 14, 2024
There was a problem hiding this comment.
@aidanleuck you also have to update the test harness: checks are failing due to this
auto-merge was automatically disabled
August 14, 2024 19:54
Head branch was pushed to by a user without write access
|
@dduportal Thanks I fixed those tests. It appears it is failing trying to download JDK, looking at past builds it appears this might be an intermittency as opposed to changes in my PR. Do we just need to keep running it again? Edit: Another PR with a similar flake https://ci.jenkins.io/blue/organizations/jenkins/Packaging%2Fdocker-agent/detail/PR-827/50/pipeline/145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#858 (this will be moved at some point)
Fixes issue with environment variables named USER being set to user due to it being merged with the variable set in the Dockerfile.
Testing done
Submitter checklist