Add support for Jenkins agent jar file location in the environment variable JENKINS_AGENT_FILE #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
previously approved these changes
Aug 16, 2024
There was a problem hiding this comment.
May I ask you to also update the associated README (https://github.com/jenkinsci/docker-agent/blob/master/README_inbound-agent.md) to document this new feature please? You may do it on this PR, or a subsequent "documentation only" PR: the easier for you!
Other than that the PR looks good to me! I'll take care (as maintainer) to have this merged and released in the next 24 hours
zhan9san
force-pushed
the
feature/jenkins-agent-jar-file
branch
from
9785210
to
a2eb9b2
Compare
dduportal
approved these changes
Aug 16, 2024
|
Great thanks. The doc is updated as well. PR is rebased from master and the commit is squashed as well |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
Fixes #859
Submitter checklist
Currently, the Jenkins agent jar file location is hardcoded in
/usr/share/jenkins/agent.jar.The jar file may be downloaded by the user who does not have write permission to directory,
/usr/share/jenkins.It would be great if the location can be customized in the environment variable.