Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Rename Windows images so that a standard DockerHub repo is used #160

Merged
merged 4 commits into from
Apr 13, 2020

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev requested a review from a team as a code owner April 12, 2020 21:54
README.md Outdated Show resolved Hide resolved
@oleg-nenashev oleg-nenashev marked this pull request as draft April 13, 2020 13:40
@oleg-nenashev
Copy link
Member Author

@slide @timja @MarkEWaite

My proposal is to use the following tags for windows:

  • jenkins/jnlp-agent:windows - equivalent of the current latest in jenkins/jnlp-agent
  • windows-jdk8 - equivalent of the current jenkins/jnlp-agent:jdk8
  • windows-jdk11 - equivalent of the current jenkins/jnlp-agent:jdk11

I will not merge this PR for now, we can integrate it after 4.3-2 and then announce Windows images as official ones

@slide
Copy link
Member

slide commented Apr 13, 2020

It should just show up as a different architecture for latest, other repos don't name windows images differently. The AdoptOpenJDK latest works for Linux and windows.

@slide
Copy link
Member

slide commented Apr 13, 2020

See here https://hub.docker.com/_/adoptopenjdk?tab=tags

The latest tag has a Linux/amd64 and a windows/amd64 variant, but both are using the latest tag.

@slide
Copy link
Member

slide commented Apr 13, 2020

Looks like we would need to use manifests to do it, so name them however you want for now. I would like to give all users the same experience (e.g., docker pull jenkins/agent) regardless of the platform, but that will have to wait I guess.

@oleg-nenashev
Copy link
Member Author

Looks like we would need to use manifests to do it, so name them however you want for now. I would like to give all users the same experience (e.g., docker pull jenkins/agent) regardless of the platform, but that will have to wait I guess

Yes, there is item for it in the roadmap. Just another reason to consoludate the build flow on Jenkins so that we can manage that

image

@oleg-nenashev oleg-nenashev marked this pull request as ready for review April 13, 2020 19:57
@oleg-nenashev
Copy link
Member Author

My proposal is to use the following tags for windows:

Postponing it to the next release. I think we could do it next week and then announce general availability of Windows images for agents

Co-Authored-By: Alex Earl <slide.o.mix@gmail.com>
@oleg-nenashev oleg-nenashev merged commit 07273d1 into master Apr 13, 2020
@oleg-nenashev oleg-nenashev deleted the rename-windows-images branch April 13, 2020 22:21
lemeurherve pushed a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Nov 19, 2023
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…nkinsci/rename-windows-images

Rename Windows images so that a standard DockerHub repo is used
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 12, 2024
…rename-windows-images

Rename Windows images so that a standard DockerHub repo is used
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants