Refresh plugin #179
Merged
Refresh plugin #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Used my admin powers to replay the build with the |
basil
force-pushed
the
refresh
branch
9 times, most recently
from
054c467
to
4b256e7
Compare
|
CC @car-roll |
car-roll
reviewed
May 22, 2023
| @@ -162,7 +162,7 @@ private Slave prepareAgentDocker() throws Exception { | |||
| case NO_INIT: | |||
| return new DumbSlave("docker", | |||
| "/home/jenkins/agent", | |||
| new SimpleCommandLauncher("docker run -i --rm jenkins/slave:3.29-2 java -jar /usr/share/jenkins/slave.jar")); | |||
| new SimpleCommandLauncher("docker run -i --rm jenkins/agent:latest-jdk11 java -jar /usr/share/jenkins/agent.jar")); | |||
There was a problem hiding this comment.
@basil thanks for the PR! Question, is it possible that the jenkins version of the agent image could get out of sync with the plugin so that it could not run? Or is that not how it works?
There was a problem hiding this comment.
Remoting is generally both forward and backward compatible, so this should not be a problem.
car-roll
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.