[Fixed JENKINS-48803] Updating PowerShell executable name on linux

[LiamLeane]

The reasoning is really stupid and I certainly hope they setup an alias in a future release but powershell is now pwsh, this is in the latest RC and is part of the GA release for powershell next week. Given all previous releases of Powershell for Linux were pre-release I propose that detecting which executable name to use should not be required; if the durable task plugin is updated then so too should powershell (alternatively they can manually alias the command until a Powershell update is applied).

ah but #51 (comment)

[jtnord]

You can not assume that this is the case.

You have JENKINS-47510 for starters which means this will always be broken on windows agents launched via SSH from a Linux master.

And even then you have the joy of what and where launcher.isUnix() may be set (because it is used before the channel is available - and then using cygwin or other SSHd servers on Windows that use / mimic / as a path would probably return true for Linux even if the referenced JIRA was fixed.

[gabloe]

This change needs to come in with some additional design. Ideally, I would like to see it as an option in Workflow Durable Task Step and then exposed in durable task so that the user can select which edition of PowerShell they want to target (Windows PowerShell, or PowerShell Core). Otherwise, there are too many different configurations to handle that go beyond checking for Windows or *nix, such as the scenario @jtnord pointed out.

[jetersen]

This does not consider Windows that may have pwsh installed