forked from awslabs/ec2-spot-jenkins-plugin
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs are not resubmitted. Looks like unexpected disconnect treated as not unexpected. #121
Labels
Comments
Just found the similar one:
|
hi, thx for report, looks like plugin should check this cause too, what version of Jenkins do you use? |
|
SrodriguezO
added a commit
to lucidsoftware/ec2-fleet-plugin
that referenced
this issue
Sep 9, 2020
(computer.getOfflineCause() instanceof OfflineCause.ChannelTermination) does not always hold after an unexpected instance termination. As reported in issue jenkinsci#121, the offline cause is sometimes simply hudson.slaves.OfflineCause$SimpleOfflineCause; this led to executables only being occasionally resubmitted. This commit makes it so that active executables are always resubmitted regardless of the offline cause. The assumption is that active executables that fail due to an instance going offline should always be automatically rescheduled (unless disableTaskResubmit is specified)
This should now be fixed with #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Recently switched to your plugin - works great, thank you for your job. Currently using version 1.9.1.
I'v noticed that some jobs are not resubmitted.
I'v found and investigated a little bit one example.
AWS Console.
Instance termination: Server.SpotInstanceTermination: Spot instance termination
Jenkins job output
Jenkins logs:
I see that in code it only handles
OfflineCause.ChannelTermination
, so it doesn't resubmit a job, as in our cause it isclass hudson.slaves.OfflineCause$SimpleOfflineCause
.So it looks like node was terminated by AWS, but for some reason it was some not unexpected ChannelTermination.
So should this check also include other causes, or should we do some additional configuration?
The text was updated successfully, but these errors were encountered: